Improved tests for app settings and added tests for dav_base.config.modules.ModuleMeta

dav_base/tests/generic.py

@@ -12,10 +12,13 @@ from selenium import webdriver
 from selenium.webdriver.support.ui import WebDriverWait
 from selenium.webdriver.support import expected_conditions as ExpectedConditions
 
+from ..config.apps import DefaultSetting
+
 
 class AppSetting:  # pylint: disable=too-few-public-methods
-    def __init__(self, name, of=None):
+    def __init__(self, name, default, of=None):
         self.name = name
+        self.default = default
         self.of = of
 
 
@@ -26,16 +29,29 @@ class AppsTestCase(SimpleTestCase):
     def setUp(self):
         super().setUp()
         if self.app_config:
+            self.default_settings = self.app_config.default_settings
             self.configured_settings = self.app_config.settings
         else:
+            self.default_settings = ()
             self.configured_settings = None
 
-    def test_settings(self):
-        config = self.configured_settings
+    def test_defaults(self):
+        defaults = {}
+        for d in self.default_settings:
+            self.assertIsInstance(d, DefaultSetting)
+            defaults[d.name] = d.value
+
         for setting in self.settings:
             name = setting.name
-            self.assertTrue(hasattr(config, name), 'Settings do not contain {}'.format(name))
-            value = getattr(config, name)
+            self.assertIn(name, defaults.keys())
+            self.assertEqual(defaults[name], setting.default, 'Default value of {} is not correct'.format(name))
+
+    def test_configured_settings(self):
+        for setting in self.settings:
+            name = setting.name
+            self.assertTrue(hasattr(self.configured_settings, name), 'Settings do not contain {}'.format(name))
+
+            value = getattr(self.configured_settings, name)
             of = setting.of
             if of is not None:
                 self.assertIsInstance(value, of)